Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix changefeed checkpoint lag negative value error (#3013) #3536

Merged
merged 5 commits into from
Dec 8, 2021
Merged

*: fix changefeed checkpoint lag negative value error (#3013) #3536

merged 5 commits into from
Dec 8, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3013

What problem does this PR solve?

Close #3010

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note 

fix changefeed checkpoint lag negative value error

@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#3013
69650c4 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 18, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2021
Merged
@ti-chi-bot ti-chi-bot added bug-from-internal-test Bugs found by internal testing. component/metrics-logging Metrics and logging component. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR. labels Nov 18, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-5.3@eeb9e7b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 27baeae differs from pull request most recent head de73c94. Consider uploading reports for the commit de73c94 to get more accurate results

@@               Coverage Diff                @@
##             release-5.3      #3536   +/-   ##
================================================
  Coverage               ?   56.6365%           
================================================
  Files                  ?        212           
  Lines                  ?      22941           
  Branches               ?          0           
================================================
  Hits                   ?      12993           
  Misses                 ?       8630           
  Partials               ?       1318

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 27baeae

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2021
@ti-chi-bot ti-chi-bot merged commit 1faf407 into pingcap:release-5.3 Dec 8, 2021
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asddongmen asddongmen

Labels
bug-from-internal-test Bugs found by internal testing. cherry-pick-approved Cherry pick PR approved by release team. component/metrics-logging Metrics and logging component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.3 This PR is cherry-picked to release-5.3 from a source PR.
Projects
None yet
Milestone
v5.3.1
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @codecov-commenter @amyangfei @purelind @asddongmen @nongfushanquan